code-423n4 2021-12-vader-findings issues

code-423n4 / 2021-12-vader-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Covering impermanent loss allows profiting from asymmetric liquidity provision at the expense of reserves

#189 code423n4 closed 2 years ago
1
Shorter revert messages

#188 code423n4 opened 2 years ago
0
Avoid repeated calculations

#187 code423n4 opened 2 years ago
0
Slippage control

#186 code423n4 closed 2 years ago
1
_addUSDVPair can also update

#185 code423n4 opened 2 years ago
0
list of vader pairs might grow too large

#184 code423n4 closed 2 years ago
2
Open TODOs in Codebase

#183 code423n4 opened 2 years ago
0
Cycles are not exactly 24 hours

#182 code423n4 closed 2 years ago
1
setGasThrottle function should be moved to BasePoolV2

#181 code423n4 opened 2 years ago
0
24 hour limit not applied on first mint

#180 code423n4 closed 2 years ago
1
Using single total native reserve variable for synth and non-synth reserves of VaderPoolV2 can lead to losses for synth holders

#179 code423n4 opened 2 years ago
0
VaderPoolV2 doesn't implement queue system yet

#178 code423n4 opened 2 years ago
1
Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom

#177 code423n4 closed 2 years ago
2
Redundant Constant Inheritance

#176 code423n4 opened 2 years ago
0
Changing function visibility from public to external can save gas

#175 code423n4 opened 2 years ago
0
Gas Optimization: Reduce the size of error messages (Long revert Strings)

#174 code423n4 closed 2 years ago
1
BasePoolV2.rescue function allows an attacker to routinely withdraw all mistakenly sent funds

#173 code423n4 closed 2 years ago
1
Incorrect descriptions of BasePoolV2's _onlyRouter and _supportedToken

#172 code423n4 opened 2 years ago
0
onlyDAO modifier of VaderPoolFactory is actually onlyOwner

#171 code423n4 closed 2 years ago
1
Chainlink price of a round with zero commit timestamp is accepted as current

#170 code423n4 closed 2 years ago
2
Chainlink USD pairs decimals are hard coded as a required condition for the addition of any USD liquidity source

#169 code423n4 closed 2 years ago
1
Long Revert Strings are Waste of Gas

#168 code423n4 closed 2 years ago
1
Open Discussion That Hint Potential Security Problem Should be Avoided

#167 code423n4 opened 2 years ago
0
Avoiding Initialization of Loop Index If It Is 0

#166 code423n4 closed 2 years ago
1
mintSynth() can transfer funds from an arbitrary address

#165 code423n4 closed 2 years ago
1
`USDV.sol` Mint and Burn Amounts Are Incorrect

#164 code423n4 opened 2 years ago
1
Price Calculation Favours Higher Priced Token Pairs

#163 code423n4 closed 2 years ago
1
Can mint more than `dailyLimit` in `USDV`

#162 code423n4 closed 2 years ago
2
Gas Optimization: Avoid list manipulation

#161 code423n4 closed 2 years ago
1
Adding pair of the same `foreignAsset` would replace oracle of earlier entry

#160 code423n4 opened 2 years ago
0
Able to add duplicated USDVPair

#159 code423n4 closed 2 years ago
2
Unable to remove/change USDVPair

#158 code423n4 closed 2 years ago
1
`uint a = b++;` is a confusing syntax and can be gas-optimized

#157 code423n4 opened 2 years ago
0
`LiquidityBasedTWAP.getStaleUSDVPrice()` Gas Optimization

#156 code423n4 closed 2 years ago
1
`LiquidityBasedTWAP.getStaleVaderPrice()` Gas Optimization

#155 code423n4 closed 2 years ago
1
Missing lower bound of dailyLimit argument could indefinitely lock minting process

#154 code423n4 closed 2 years ago
2
Immutable variable

#153 code423n4 closed 2 years ago
1
Keccak functions in constants waste gas

#152 code423n4 opened 2 years ago
0
Missing boundary check in USDV.sol

#151 code423n4 opened 2 years ago
2
Guardian Is not Set On The Constructor

#150 code423n4 closed 2 years ago
0
USDV TWAP averages wrong

#149 code423n4 closed 2 years ago
1
Vader TWAP averages wrong

#148 code423n4 opened 2 years ago
0
`VaderPoolV2` minting synths & fungibles can be frontrun

#147 code423n4 opened 2 years ago
0
`rewardRate` parameter are not updated in time

#146 code423n4 closed 2 years ago
0
Incompatibility With Rebasing/Deflationary/Inflationary tokens

#145 code423n4 closed 2 years ago
0
Cache array length in for loops can save gas

#144 code423n4 closed 2 years ago
1
++i is more gas efficient than i++ in loops forwarding

#143 code423n4 closed 2 years ago
1
mintSynth might mint nothing

#142 code423n4 opened 2 years ago
1
Public function that should be declared external (2)

#141 code423n4 closed 2 years ago
1
Lack of address(0) check

#140 code423n4 opened 2 years ago
1