code-423n4 2021-12-vader-findings issues

code-423n4 / 2021-12-vader-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

vader can be initialized twice

#139 code423n4 opened 2 years ago
0
Adding unchecked directive can save gas

#138 code423n4 closed 2 years ago
1
Lack Of Router Setter Function

#137 code423n4 opened 2 years ago
0
vader price is wrong

#136 code423n4 closed 2 years ago
1
denial of service

#135 code423n4 closed 2 years ago
2
loss of precision

#134 code423n4 opened 2 years ago
0
Internal functions can be private if the contract is not herited

#133 code423n4 opened 2 years ago
0
Public function that should be declared external

#132 code423n4 closed 2 years ago
1
Missing checks for non-zero transfer value calls

#131 code423n4 closed 2 years ago
0
Save Gas With The Unchecked Keyword

#130 code423n4 opened 2 years ago
0
Lack of decimal control in StakingRewards

#129 code423n4 opened 2 years ago
1
Lack of check of inputs in StakingRewards

#128 code423n4 opened 2 years ago
0
Unsafe transfers in LinearVesting

#127 code423n4 closed 2 years ago
1
Explicit initialization with zero not required

#126 code423n4 opened 2 years ago
0
Unsafe transfers in Converter.sol

#125 code423n4 closed 2 years ago
1
Unnecessary checked arithmetic in for-loops

#124 code423n4 closed 2 years ago
1
`++i` costs less gass compared to `i++`

#123 code423n4 opened 2 years ago
0
An array's length should be cached to save gas in for-loops

#122 code423n4 opened 2 years ago
0
Explicit overflow checks in solidity 0.8 is unnecessary

#121 code423n4 closed 2 years ago
1
SafeMath is not needed when using Solidity version 0.8.*

#120 code423n4 opened 2 years ago
0
Open TODOs

#119 code423n4 closed 2 years ago
1
mintSynth and mintFungible function are not verified from==msg.sender

#118 code423n4 closed 2 years ago
1
USDV LockCreated event should include the index of a created lock

#117 code423n4 opened 2 years ago
0
Open TODOs

#116 code423n4 closed 2 years ago
1
Less than 256 uints are not gas efficient

#115 code423n4 opened 2 years ago
0
setGuardian should be two step process

#114 code423n4 closed 2 years ago
1
transferOwnership should be two step process

#113 code423n4 opened 2 years ago
0
`> 0` can be replaced with `!= 0` for gas optimization

#112 code423n4 opened 2 years ago
0
SHOULD CHECK RETURN DATA FROM CHAINLINK AGGREGATORS (Timestamp)

#111 code423n4 opened 2 years ago
0
Out of gas.

#110 code423n4 opened 2 years ago
2
`foreignPrice` Is Not Scaled To 18 Decimals In `getChainlinkPrice`

#109 code423n4 closed 2 years ago
1
Anyone Can Frontrun `VaderPoolV2.mintFungible()` To Steal Fungible Tokens

#108 code423n4 closed 2 years ago
1
Anyone Can Frontrun `VaderPoolV2.mintSynth()` To Steal Synthetic Assets

#107 code423n4 closed 2 years ago
1
`USDV.claim` Does Not Check If Index Is Valid

#106 code423n4 opened 2 years ago
2
`totalLiquidityWeight` Is Updated When Adding New Token Pairs Which Skews Price Data For `getVaderPrice` and `getUSDVPrice`

#105 code423n4 opened 2 years ago
0
No Method To Remove Token Pairs

#104 code423n4 opened 2 years ago
0
`previousPrices` Is Never Updated Upon Syncing Token Price

#103 code423n4 opened 2 years ago
0
`_addVaderPair` and `_addUSDVPair` Does Not Check For Duplicate Token Pairs

#102 code423n4 opened 2 years ago
0
Insufficient access control on VaderPoolV2.mintSynth allows theft of user funds

#101 code423n4 closed 2 years ago
1
Test - testing

#100 code423n4 closed 2 years ago
0
validateGas does nothing

#99 code423n4 opened 2 years ago
1
denial of service

#98 code423n4 opened 2 years ago
0
Users can lock themselves out of being able to convert VETH, becoming stuck with the deprecated asset

#97 code423n4 opened 2 years ago
0
Inclusion of salt and chainId in merkle tree leaves increases gas costs for no reason.

#96 code423n4 opened 2 years ago
1
mintSynth can be frontrun to steal money

#95 code423n4 closed 2 years ago
1
burn function doesn't check if uAmount is greater than zero yet still creates locks

#94 code423n4 closed 2 years ago
1
safeTransferFrom should be used in mint() function

#93 code423n4 closed 2 years ago
2
No check that vAmount is greater than 0 allows to create useless locks

#92 code423n4 closed 2 years ago
1
looping usdvPairs dynamic array can cause out of gas errors

#91 code423n4 closed 2 years ago
1
loop over dynamic arrays can cause out of gas errors

#90 code423n4 closed 2 years ago
1

Previous Next