code-423n4 2021-12-yetifinance-findings issues

code-423n4 / 2021-12-yetifinance-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Return Value from `transfer` Function is Not Checked

#303 code423n4 closed 2 years ago
3
No Price Oracle Support for LP and Interest-bearing Tokens

#302 code423n4 closed 2 years ago
2
Missing return statements

#301 code423n4 opened 2 years ago
4
claimYeti inclusive check

#300 code423n4 opened 2 years ago
3
Gas Optimization: Unnecessary variables

#299 code423n4 opened 2 years ago
1
Use safeTransfer/safeTransferFrom consistently

#298 code423n4 closed 2 years ago
3
assert() used instead of require()

#297 code423n4 closed 2 years ago
2
_isBeforeFeeBootstrapPeriod inside the loop

#296 code423n4 opened 2 years ago
1
_openTroveInternal() within openTrove function on line 275 (BorrowOperations.sol) has an error in accounting logic that will affect important calculations such as vars.YusdFee et al

#295 code423n4 closed 2 years ago
2
Cache repeated calculations

#294 code423n4 opened 2 years ago
0
Assigned operations to constant variables

#293 code423n4 closed 2 years ago
1
exists check passes when validCollateral length is 0

#292 code423n4 opened 2 years ago
2
`_redeemCaller` should not obtain rights to future rewards for the `WJLP` they redeemed

#291 code423n4 opened 2 years ago
3
Attacker can steal future rewards of `WJLP` from other users

#290 code423n4 opened 2 years ago
2
Cache storage variables in the stack can save gas

#289 code423n4 opened 2 years ago
0
Unused named returns

#288 code423n4 closed 2 years ago
3
Infinite mint

#287 code423n4 opened 2 years ago
4
Unsafe approve in sYETIToken

#286 code423n4 opened 2 years ago
3
Missing access restriction on StabilityPool's receiveCollateral

#285 code423n4 closed 2 years ago
1
Liquidation can be escaped by depositing a WJLP with `_rewardOwner` != `_borrower`

#284 code423n4 opened 2 years ago
1
Cache array length in for loops can save gas

#283 code423n4 opened 2 years ago
2
Remove unnecessary variables can make the code simpler and save some gas

#282 code423n4 closed 2 years ago
1
Only using `SafeMath` when necessary can save gas

#281 code423n4 opened 2 years ago
1
Use of assert() instead of require()

#280 code423n4 closed 2 years ago
3
Only use `amount` when needed can save gas

#279 code423n4 opened 2 years ago
0
Inline unnecessary function can make the code simpler and save some gas

#278 code423n4 opened 2 years ago
0
`HintHelpers.sol#setAddresses()` can be replaced with `constructor` and save gas

#277 code423n4 opened 2 years ago
1
`setAddresses()` functions can be front run

#276 code423n4 closed 2 years ago
1
Returning the named returns is redundant

#275 code423n4 closed 2 years ago
2
`10 ** 18` can be changed to `1e18` and save some gas

#274 code423n4 opened 2 years ago
2
Check if amount > 0 before token transfer can save gas

#273 code423n4 closed 2 years ago
1
Use immutable variable can save gas

#272 code423n4 closed 2 years ago
1
Change `public` constant variables to `private` / `internal` can save gas

#271 code423n4 closed 2 years ago
1
Public functions not used by current contract should be external

#270 code423n4 opened 2 years ago
2
Deadline based on `block.timestamp` is ineffective for contract calls, removing them can make the code simpler and save gas

#269 code423n4 closed 2 years ago
2
Tokens with fee on transfer are not supported

#268 code423n4 opened 2 years ago
2
Unchecked return value for `token.transfer` call

#267 code423n4 closed 2 years ago
4
Use short reason strings can save gas

#266 code423n4 closed 2 years ago
1
Missing error messages in require statements

#265 code423n4 opened 2 years ago
2
Lack of access control allows attacker to call `wrap()` and steal other user's wallet balance

#264 code423n4 closed 2 years ago
2
TeamLockup releases more tokens that it should

#263 code423n4 opened 2 years ago
2
Upgrade pragma to at least 0.8.4 is more gas efficient

#262 code423n4 closed 2 years ago
1
Adding unchecked directive can save gas

#261 code423n4 opened 2 years ago
1
`ERC20_8.sol`, `WJLP.sol` SafeMath is no longer needed

#260 code423n4 closed 2 years ago
2
`ERC20_8.sol` `totalSupply` should be increased on `mint` and decreased on `burn`

#259 code423n4 opened 2 years ago
3
Chainlink's `latestRoundData` might return stale results

#258 code423n4 closed 2 years ago
1
Setting `uint` variables to `0` is redundant

#257 code423n4 closed 2 years ago
1
`console.log()` should be deleted

#256 code423n4 closed 2 years ago
1
Unused imports

#255 code423n4 closed 2 years ago
1
`++i` is more efficient than `i++`

#254 code423n4 closed 2 years ago
1