code-423n4 2022-01-timeswap-findings issues

code-423n4 / 2022-01-timeswap-findings

2 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Open TODOs

#138 code423n4 opened 2 years ago
1
Missing input validation on array lengths (PayMath.sol)

#137 code423n4 opened 2 years ago
1
Use assignment not += in function mint (TimeswapPair.sol)

#136 code423n4 opened 2 years ago
1
Typos

#135 code423n4 opened 2 years ago
1
Open TODOs

#134 code423n4 closed 2 years ago
1
Griefing attack can prevent almost all activity in a pool

#133 code423n4 closed 2 years ago
1
Outdated OpenZeppelin dependency

#132 code423n4 opened 2 years ago
2
XSS via SVG Construction contract

#131 code423n4 opened 2 years ago
1
Gas: Break out of loop to save gas

#130 code423n4 opened 2 years ago
0
messing with the dues ids for victim user

#129 code423n4 opened 2 years ago
1
immutable variables `fee` and `protocolFee` are unbounded

#128 code423n4 closed 2 years ago
1
`TimeswapConvenience.payETHAsset()` allows the user to pay with the contract's own funds

#127 code423n4 closed 2 years ago
3
calculate a condition before the loop instead of calculating it in every iteration

#126 code423n4 opened 2 years ago
1
call a function and save its return value before the loop instead of calling it in every iteration

#125 code423n4 closed 2 years ago
1
subtract values in the if statement to avoid a useless operation

#124 code423n4 opened 2 years ago
1
saving array elements in a variable to prevent multiple accessing to the memory

#123 code423n4 closed 2 years ago
2
Gas: `> 0` is less efficient than `!= 0` for unsigned integers

#122 code423n4 closed 2 years ago
2
loop index prefix instead of postfix

#121 code423n4 closed 2 years ago
1
Gas: No need to initialize variables with default values

#120 code423n4 opened 2 years ago
1
frontrun Temporary Dos attack

#119 code423n4 opened 2 years ago
2
timeswap testnet

#118 code423n4 closed 2 years ago
0
timeswap testnet

#117 code423n4 closed 2 years ago
0
Debt created during mint is arbitragable

#116 code423n4 closed 2 years ago
2
Debt created during mint is arbitragable

#115 code423n4 closed 2 years ago
2
`safeSymbol()` can revert causing DoS

#114 code423n4 opened 2 years ago
1
`safeName()` can revert causing DoS

#113 code423n4 opened 2 years ago
1
safeDecimals can revert causing DoS

#112 code423n4 opened 2 years ago
1
`burn()` doesn't call ERC721 `_burn()`

#111 code423n4 opened 2 years ago
1
Two pairs can have same ERC20 tokens

#110 code423n4 closed 2 years ago
2
Remove salt from createPair()

#109 code423n4 opened 2 years ago
1
Incorrect Q in comment

#108 code423n4 opened 2 years ago
1
Caching weth in timeswapMintCallback can save gas

#107 code423n4 opened 2 years ago
1
Caching pair in timeswapPayCallback can save gas

#106 code423n4 opened 2 years ago
1
acceptOwner should reset pendingOwner

#105 code423n4 closed 2 years ago
1
Constructor Does Not Check for Zero Addresses for _factory and _weth

#104 code423n4 opened 2 years ago
1
There are different claiming times on the test net.

#103 code423n4 closed 2 years ago
0
Less than 256 uints are not gas efficient

#102 code423n4 opened 2 years ago
1
Revert String Size Optimization

#101 code423n4 closed 2 years ago
1
Missing Decimal Check When adding pairs

#100 code423n4 closed 2 years ago
2
Openzeppelin Contract Vulnerability

#99 code423n4 closed 2 years ago
2
WETH9 example uses payable.transfer

#98 code423n4 opened 2 years ago
1
TimeswapPair.pay doesn't check for non-existent debt owner

#97 code423n4 opened 2 years ago
1
Borrowing of the whole asset supply can yield a low-level division revert

#96 code423n4 opened 2 years ago
1
WithdrawMath.getCollateral reads storage repetitively for the same state variables that don’t change

#95 code423n4 opened 2 years ago
1
TimeswapPair's burn miss current pool liquidity check

#94 code423n4 opened 2 years ago
1
Convenience contract fails to function if asset or collateral is an ERC20 token with fees

#93 code423n4 opened 2 years ago
3
more efficient lock() modifier

#92 code423n4 closed 2 years ago
1
using '!=' instead of '<' or '>'

#91 code423n4 closed 2 years ago
1
Gas savings

#90 code423n4 closed 2 years ago
3
more efficient gas usage by removing && operator

#89 code423n4 opened 2 years ago
1

Previous Next