issues
search
code-423n4
/
2022-04-badger-citadel-findings
0
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
IVesting(vesting).setupVesting is not implemented in StakedCitadelVester.sol.
#189
code423n4
closed
2 years ago
2
GlobalAccessControl roles admin not set and CONTRACT_GOVERNANCE_ROLE can change admin even if it is not an admin
#188
code423n4
closed
2 years ago
2
Use of whenNotPaused, or gacPausable() for functions protected by governance role
#187
code423n4
closed
2 years ago
2
Linear vesting logic is incorrect for subsequent withdrawals
#186
code423n4
closed
2 years ago
2
no sanity checks on minDiscount
#185
code423n4
opened
2 years ago
2
Race between governance and strategist on other token earned
#184
code423n4
closed
2 years ago
1
StakedCitadel withdraw when available balance is not sufficient --> rekt some of the capital of the user
#183
code423n4
opened
2 years ago
2
Strategist can make atomic changes that benefit him/her
#182
code423n4
closed
2 years ago
3
Gas Optimizations
#181
code423n4
opened
2 years ago
2
QA Report
#180
code423n4
opened
2 years ago
3
Gas Optimizations
#179
code423n4
opened
2 years ago
0
Code credits fee-on-transfer tokens for amount stated, not amount transferred
#178
code423n4
closed
2 years ago
2
QA Report
#177
code423n4
opened
2 years ago
0
Stale price used when `citadelPriceFlag` is cleared
#176
code423n4
opened
2 years ago
3
Missing check in `setCitadelAssetPriceBounds()`.
#175
code423n4
closed
2 years ago
2
Staked Citadel function `balance` and `reportHarvest`
#174
code423n4
closed
2 years ago
2
`deposit()`ing when there is no discount results in zero xCitadel bought
#173
code423n4
closed
2 years ago
2
Function claim() in StakedCitadelVester.sol not protected when protocol in pause mode
#172
code423n4
closed
2 years ago
2
first depositor in StakedCitadel can drain other depositors
#171
code423n4
closed
2 years ago
2
QA Report
#170
code423n4
opened
2 years ago
0
Gas Optimizations
#169
code423n4
opened
2 years ago
0
Out of Gas can block the MedianOracle
#168
code423n4
opened
2 years ago
2
withdrawal amount might be wrong
#167
code423n4
closed
2 years ago
2
Gas Optimizations
#166
code423n4
opened
2 years ago
0
Function name doesn't match the interface
#165
code423n4
closed
2 years ago
1
QA Report
#164
code423n4
opened
2 years ago
0
QA Report
#163
code423n4
opened
2 years ago
0
Gas Optimizations
#162
code423n4
opened
2 years ago
0
QA Report
#161
code423n4
opened
2 years ago
0
Gas Optimizations
#160
code423n4
opened
2 years ago
0
Funding contract calculate `citadelAmount` wrongly
#159
code423n4
closed
2 years ago
3
New vest reset `unlockBegin` of existing vest without removing vested amount
#158
code423n4
opened
2 years ago
3
QA Report
#157
code423n4
opened
2 years ago
0
Gas Optimizations
#156
code423n4
opened
2 years ago
0
QA Report
#155
code423n4
opened
2 years ago
0
QA Report
#154
code423n4
closed
2 years ago
0
QA Report
#153
code423n4
opened
2 years ago
0
Gas Optimizations
#152
code423n4
opened
2 years ago
0
Wrong `getAmountOut` calculation
#151
code423n4
closed
2 years ago
1
the earning amount can bypass toEarnBps
#150
code423n4
opened
2 years ago
2
Funding.deposit() doesn't work if there is no discount set
#149
code423n4
opened
2 years ago
1
QA Report
#148
code423n4
closed
2 years ago
0
minDiscound can be greater than maxDiscount
#147
code423n4
closed
2 years ago
2
cannot set asset cap to the current cumulative funded amount
#146
code423n4
closed
2 years ago
1
Gas Optimizations
#145
code423n4
opened
2 years ago
0
QA Report
#144
code423n4
opened
2 years ago
0
DoS at CitadelMinter.sol
#143
code423n4
closed
2 years ago
3
User funds stuck - buy works even after sale ends
#142
code423n4
closed
2 years ago
1
Citadel price may malfunction due to number of Oracle provider setting
#141
code423n4
closed
2 years ago
2
Sale parameters can be changed even after sale has started
#140
code423n4
closed
2 years ago
2
Previous
Next