issues
search
code-423n4
/
2022-06-putty-findings
5
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
asset can be stucked in the contract if transfer 0 fee
#267
code423n4
closed
2 years ago
1
An attacker can make a scam with an option that uses a real NFT but can't be exercised.
#266
code423n4
closed
2 years ago
1
Contract allows to create orders with duration=0 but it's not possible to immediately exercise or withdraw those orders after filling because of strict expiration condition for positionExpirations (in general when block.timestamp==positionExpirations it's not possible to exercise or withdraw order)
#265
code423n4
closed
2 years ago
2
QA Report
#264
code423n4
opened
2 years ago
0
Gas Optimizations
#263
code423n4
closed
2 years ago
1
Gas Optimizations
#262
code423n4
opened
2 years ago
0
QA Report
#261
code423n4
opened
2 years ago
0
Gas Optimizations
#260
code423n4
closed
2 years ago
1
Functions have payable modifier but dont do anything with the ether
#259
code423n4
closed
2 years ago
3
Don't check if `value` is 0 for some paths
#258
code423n4
closed
2 years ago
2
Zero fee orders are possible
#257
code423n4
closed
2 years ago
2
Gas Optimizations
#256
code423n4
closed
2 years ago
1
QA Report
#255
code423n4
opened
2 years ago
0
It should handle fee-on-transfer tokens due to upgradable tokens
#254
code423n4
closed
2 years ago
2
QA Report
#253
code423n4
closed
2 years ago
2
Attacker may front-run `acceptCounterOffer()` cause users to take both original order and new one
#252
code423n4
closed
2 years ago
2
SignatureChecker.isValidSignatureNow allows option signers to dynamically/temporarily revoke options
#251
code423n4
closed
2 years ago
2
Doesn’t check order.baseAsset.code when exercising call order
#250
code423n4
closed
2 years ago
2
Attacker can take premium from taker who fill short-call orders for free.
#249
code423n4
closed
2 years ago
2
No portfolio calculation, low fund efficiency for the current collateral/exercise pattern
#248
code423n4
closed
2 years ago
2
Low liquidity, no way to resell the opened position
#247
code423n4
closed
2 years ago
2
Any one can mint penny NFT to take some advantage
#246
code423n4
closed
2 years ago
2
No approve before transfer
#245
code423n4
closed
2 years ago
1
Missing floor token transfer for short call
#244
code423n4
closed
2 years ago
1
Refund and withdraw could be automatic after exercised or expiry
#243
code423n4
closed
2 years ago
3
Orders could be unable to be fulfilled due to insufficient fund/underlying when when filled
#242
code423n4
closed
2 years ago
2
Gas Optimizations
#241
code423n4
opened
2 years ago
0
QA Report
#240
code423n4
opened
2 years ago
0
Gas Optimizations
#239
code423n4
opened
2 years ago
0
QA Report
#238
code423n4
opened
2 years ago
0
Gas Optimizations
#237
code423n4
opened
2 years ago
0
The order maker can cancel the order, after it has been filled.
#236
code423n4
opened
2 years ago
2
QA Report
#235
code423n4
opened
2 years ago
0
Gas Optimizations
#234
code423n4
opened
2 years ago
0
QA Report
#233
code423n4
opened
2 years ago
1
Fee could be zero and reverts on transfer
#232
code423n4
closed
2 years ago
1
Use `_safeMint` instead of `_mint`
#231
code423n4
closed
2 years ago
1
QA Report
#230
code423n4
opened
2 years ago
0
Gas Optimizations
#229
code423n4
opened
2 years ago
0
QA Report
#228
code423n4
opened
2 years ago
0
Unbounded loops may cause `exercise()`s and `withdraw()`s to fail
#227
code423n4
opened
2 years ago
3
`fillOrder()` and `exercise()` may lock Ether sent to the contract, forever
#226
code423n4
opened
2 years ago
4
Put/call options may be lost if the maker/filler is unable to handle ERC-721 tokens
#225
code423n4
closed
2 years ago
1
Makers may be unable to withdraw assets 'put' to them if the fee is zero
#224
code423n4
closed
2 years ago
1
Put option sellers can prevent exercise by specifying zero amounts, or non-existant tokens
#223
code423n4
opened
2 years ago
3
QA Report
#222
code423n4
closed
2 years ago
1
Short Call Maker Asset Can Be Frozen
#221
code423n4
closed
2 years ago
2
Gas Optimizations
#220
code423n4
opened
2 years ago
0
QA Report
#219
code423n4
opened
2 years ago
1
Gas Optimizations
#218
code423n4
opened
2 years ago
0
Previous
Next