issues
search
code-423n4
/
2024-06-thorchain-findings
6
stars
3
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
[M-02] Incorrect call argument in `THORChain_Router::_transferOutAndCallV5`, leading to grief/steal of `THORChain_Aggregator`'s funds or DoS
#55
howlbot-integration[bot]
opened
3 months ago
2
[M-03] Indirect use of `msg.value` in for loop, causing DoS of `THORChain_Router::batchTransferOutAndCallV5`
#54
howlbot-integration[bot]
closed
3 months ago
1
Rebasing tokens are not handled correctly
#53
howlbot-integration[bot]
closed
2 months ago
4
[H-03] Incorrect event emissions, tricking the `smartcontract_log_parser`
#52
howlbot-integration[bot]
closed
3 months ago
1
Batch transfers will not work.
#51
howlbot-integration[bot]
closed
3 months ago
1
BatchTransferOutAndCallV5 iterate msg value
#50
howlbot-integration[bot]
closed
3 months ago
2
Any Eth in router contract can be stolen by a malicious user
#49
howlbot-integration[bot]
closed
3 months ago
3
Incorrect Ether Distribution in `batchTransferOutAndCallV5` Function
#48
howlbot-integration[bot]
closed
3 months ago
2
ETH is sent to the aggregator contract instead of Recipient Address.
#47
howlbot-integration[bot]
closed
3 months ago
2
SwapOutV5 : Fees are not deducted from the fromAmount on `Fee On Transfer ERC20 Token's` Transaction.
#46
howlbot-integration[bot]
closed
3 months ago
1
The router contract is not compatible with fee-on-transfer tokens
#45
howlbot-integration[bot]
closed
3 months ago
1
Due to the use of `msg.value` in for loop, anyone can drain all the funds from the `THORChain_Router` contract
#44
howlbot-integration[bot]
opened
3 months ago
3
Attacker can steal shares of "vault-like" tokens, such as stETH, that should belong to legitimate vaults
#43
howlbot-integration[bot]
closed
2 months ago
7
Calling `_transferOutAndCallV5` function with `aggregationPayload.fromAsset` being `address(0)` causes vault to incorrectly send `msg.value` to target aggregator instead of recipient when calling target aggregator's `swapOutV5` function reverts
#42
howlbot-integration[bot]
closed
3 months ago
2
THORChain_Router:TransferOut event will be emitted even it the ETH transfer wasn't successful
#41
howlbot-integration[bot]
closed
3 months ago
1
`_transferOutAndCallV5` function is incompatible for the Fee-on-Transfer tokens
#40
howlbot-integration[bot]
closed
3 months ago
1
`batchTransferOutAndCallV5` might revert if there are more than 2 calls, which transfer ETH
#39
howlbot-integration[bot]
closed
3 months ago
1
The new `_transferOutAndCallV5()` function is not compatible with fee-on-transfer and rebase tokens
#38
howlbot-integration[bot]
closed
3 months ago
2
Events arent being logged and parsed properly according to the docs.
#37
howlbot-integration[bot]
closed
3 months ago
3
Assets can be stolen after a swap attempt in `_transferOutAndCallV5()`
#36
howlbot-integration[bot]
closed
3 months ago
2
ETH is sent to the wrong address
#35
howlbot-integration[bot]
closed
3 months ago
2
`batchTransferOutAndCallV5` function is broken, it will not work in some cases and in some cases it will emit wrong event values.
#34
howlbot-integration[bot]
closed
3 months ago
1
Native token is sent to the wrong address in `_transferOutAndCallV5()` leading to the theft of these assets
#33
howlbot-integration[bot]
closed
3 months ago
3
When dealing with native coin, the `TransferOut*` events are still triggered on error
#32
howlbot-integration[bot]
closed
3 months ago
2
`_transferOutAndCallV5()` is incompatible with fee on transfer tokens
#31
howlbot-integration[bot]
closed
3 months ago
1
`batchTransferOutAndCallV5` will be unusable due to msg.value in a loop type situation.
#30
howlbot-integration[bot]
closed
3 months ago
1
Incorrect Event Emission due to Ether Transfer Failure in THORChain Router Contract
#29
howlbot-integration[bot]
closed
3 months ago
2
Some of token's underlying assets for corresponding vault can fail to be transferred when such token is a rebasing token or token with airdrops, such as AMPL
#28
howlbot-integration[bot]
closed
2 months ago
4
`Fund stuck forever` in vault in case of multiple deposits to different vaults
#27
howlbot-integration[bot]
closed
3 months ago
9
`batchTransferOutV5` could emit multiple `TransferOut` events, but Bifrost Observation can handle only one per transaction.
#26
howlbot-integration[bot]
closed
3 months ago
6
Users will be denied from using a particular protocol functionality under a certain case
#25
howlbot-integration[bot]
closed
2 months ago
12
Bifrost `risk of DoS` due to the increase in transactions and events to process
#24
howlbot-integration[bot]
opened
3 months ago
7
smartcontract_log_parser.go client is setting `isVaultTransfer` to true in the vaultTransferEvent case
#23
howlbot-integration[bot]
closed
3 months ago
5
Bifrost `risk of griefing attack` due to missing early exit path for `transferOutAndCall`
#22
howlbot-integration[bot]
opened
3 months ago
27
Gas Price Overestimation Due to Incorrect Standard Deviation Calculation.
#21
howlbot-integration[bot]
closed
3 months ago
3
The `TransferOutAndCallV5` event is not caught by `smartcontract_log_parser.go`
#20
howlbot-integration[bot]
closed
3 months ago
6
[H-02] Incorrect recipient inside `THORChain_Router::_transferOutAndCallV5`, leading to sending gas asset to the payload target, not the recipient
#19
howlbot-integration[bot]
closed
3 months ago
12
looping through the whiteList aggregator even though disableWhitelist=1
#18
howlbot-integration[bot]
closed
3 months ago
7
ThorChain will be informed wrongly about the unsuccessful ETH transfers due to the incorrect events emissions
#17
howlbot-integration[bot]
opened
3 months ago
3
`aggregationPayload.fromAmount` of an ERC20 token can be lost when calling `_transferOutAndCallV5` function for such token if target aggregator's `swapOutV5` function call reverts
#16
howlbot-integration[bot]
closed
3 months ago
6
Calling `_transferOutAndCallV5` function is always DOS'ed for all vaults when corresponding ERC20 token is a fee-on-transfer token, such as STA
#15
howlbot-integration[bot]
closed
3 months ago
3
`earlyExit` is not set to true in `transferAllowanceEvent` case in `smartcontract_log_parser:GetTxInItem`
#14
c4-bot-1
closed
2 months ago
7
`_transferOutAndCallV5` Doesn't Return Funds to Recipient with Failing Aggregator
#13
c4-bot-7
closed
3 months ago
3
`batchTransferOutAndCallV5` Fails Due to Out of Funds
#12
c4-bot-1
closed
3 months ago
1
`_transferOutAndCallV5` Does Not Send Gas Token to Recipient on Failing Aggregator
#11
c4-bot-7
closed
3 months ago
2
Excess Ether Not Returned in `transferOutV5` and `batchTransferOutV5` Functions
#10
c4-bot-10
closed
3 months ago
4
QA Report
#9
c4-bot-1
closed
3 months ago
1
When calling the batchTransferOutV5 functions, some events may be filtered out
#8
c4-bot-10
closed
3 months ago
3
Use of msg.value in _transferOutAndCallV5 loop breaks batchTransferOutAndCallV5 batch functionality.
#7
c4-bot-1
closed
3 months ago
4
Update readme
#6
liveactionllama
closed
3 months ago
0
Previous
Next