code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.
https://www.codecorps.org
MIT License
234 stars 86 forks source link

Ignore repo syncs for projects without project id. #1254

Closed asummers closed 6 years ago

asummers commented 6 years ago

Fixes #1221

joshsmith commented 6 years ago

Just note to self that you're working this to:

asummers commented 6 years ago

Things to consider moving forward:

There are "classes" of webhooks, some of which pertain to the repository and project and other that don't (installation, e.g.). As CC adds more webhook handlers for various reasons, the should_process? function will become increasingly further away from the handler logic, so this should eventually move down into the event handler logic, with the controller merely being a dispatcher.

joshsmith commented 6 years ago

With that change and a squash into a single commit we're good to merge this.