Update conversation route

code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.

https://www.codecorps.org

MIT License

234 stars 86 forks source link

Update conversation route #1309

Closed snewcomer closed 6 years ago

snewcomer commented 6 years ago

Fixes #1308

snewcomer commented 6 years ago

Actually not sure why my commits were changed but tons of merge conflicts

joshsmith commented 6 years ago

@snewcomer I had rebased for you. Sorry about that. Was trying to be helpful but was not.

snewcomer commented 6 years ago

@joshsmith ah no worries! I thought I did something. Does this need tracking? Not totally sure what the strategy as it relates to tracking....

joshsmith commented 6 years ago

We can circle back to figure out the tracking/analytics side of this later. I haven't really formed a coherent strategy around it yet for this feature set.

snewcomer commented 6 years ago

@joshsmith fixed! Thanks for reviewing it all!

joshsmith commented 6 years ago

🙌