Ensure organization user type is downcased

malandrina commented 6 years ago

Update CodeCorps.GitHub.Adapters.User#transform_type/1 to downcase the "Organization" GitHub user type
Add migration for transforming existing data

Feedback sought:

For transforming the data, would a one-off Mix task (or something like that) be preferable to a migration?
If a migration is preferable, what should the down method do in an irreversible migration? My implementation defines an empty down method but I'm not sure if that's conventional.
I wrote the migration query in SQL. Would you prefer a more Elixir-heavy implementation like the one shown in the description of https://github.com/code-corps/code-corps-api/issues/1345?

malandrina commented 6 years ago

On the matter of a down migration, I'd expect we'd just do the opposite transformation.

Ah yes, that makes sense. I amended my previous commit and force-pushed.

joshsmith commented 6 years ago

🙌

code-corps / code-corps-api