Open begedin opened 6 years ago
@begedin Any major changes coming up to this or should i start working? Talking with reference similar to this https://github.com/code-corps/code-corps-api/issues/1374#issuecomment-361160258
@vishaldeepak Same as #1374, I would recommend branching off of #1370 and then submitting a PR against that onne. Once #1370 is merged, we can then rebase onto develop
.
Going to jump on this one since its still up for grabs ...
Problem
GitHub.Sync.pull_request_event/1
is currently completely untested. Since we want to unit test it's individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined byGitHub.Sync.pull_request_event_outcome()
Subtasks
{:ok, map}
outcome{:error, :repo_not_found}
outcome{:error, :fetching_issue, struct}
outcome{:error, :validating_github_pull_request, Changeset.t()}
outcome{:error, :validating_github_issue, Changeset.t()}
outcome{:error, :validating_user, Changeset.t()}
outcome{:error, :multiple_issue_users_match}
outcome{:error, :validating_task, Changeset.t()}
outcome{:error, :unexpected_transaction_outcome, any}
outcome