code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.
https://www.codecorps.org
MIT License
235 stars 86 forks source link

Write tests for GitHub.Sync.pull_request_event/1 #1372

Open begedin opened 6 years ago

begedin commented 6 years ago

Problem

GitHub.Sync.pull_request_event/1 is currently completely untested. Since we want to unit test it's individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined by GitHub.Sync.pull_request_event_outcome()

Subtasks

vishaldeepak commented 6 years ago

@begedin Any major changes coming up to this or should i start working? Talking with reference similar to this https://github.com/code-corps/code-corps-api/issues/1374#issuecomment-361160258

begedin commented 6 years ago

@vishaldeepak Same as #1374, I would recommend branching off of #1370 and then submitting a PR against that onne. Once #1370 is merged, we can then rebase onto develop.

zacck-zz commented 6 years ago

Going to jump on this one since its still up for grabs ...