code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.
https://www.codecorps.org
MIT License
235 stars 86 forks source link

Write tests for GitHub.Sync.installation_event/1 #1373

Closed begedin closed 6 years ago

begedin commented 6 years ago

Problem

GitHub.Sync.installation_event/1 is currently completely untested. Since we want to unit test its individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined by GitHub.Sync.installation_event_outcome()

Subtasks

zacck-zz commented 6 years ago

Looks like the second clause is rather difficult to test as it is covered by other fail safes