code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.
https://www.codecorps.org
MIT License
235 stars 86 forks source link

Write tests for GitHub.Sync.installation_repositories_event/1 #1374

Closed begedin closed 6 years ago

begedin commented 6 years ago

Problem

GitHub.Sync.installation_repositories_event/1 is currently completely untested. Since we want to unit test it's individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined by GitHub.Sync.installation_repositories_event_outcome()

Subtasks

zacck-zz commented 6 years ago

@begedin I'd like to attempt getting this one done, Will get to you with questions

begedin commented 6 years ago

@zacck You might need to work off of #1370 since that one has some pretty major changes to the underlying code.

zacck-zz commented 6 years ago

@begedin awesome will look at it