Closed zacck-zz closed 6 years ago
@zacck If you rebase off of develop now, the build should pass
@begedin appears to still fail, However the CircleCI email says the other steps ran successfully
Erm I think I broke something ...
hey @zacck
The rebase broke. I managed to clean it up and rebase correctly, so it looks good to go now.
Some general tips on rebasing PR-s
git checkout develop
git pull
git checkout your branch
git rebase -i origin/develop
This gives you an interactive rebase where you can also squash your many tiny commits into bigger ones, etc.
We still prefer to use the UI here on the site for quick rebases and squashes, but generally, as soon as you get any conflicts with the base branch, you'll wanna do it from the command line.
@begedin thank you so much for the tips, will try to keep them in mind for the next time.
What's in this PR?
This is a work in progress for test for the installation repositories even
References
Fixes #1374
Progress on: #