code-corps / code-corps-api

Elixir/Phoenix API for Code Corps.
https://www.codecorps.org
MIT License
235 stars 86 forks source link

Tests for GitHub.Sync.installation_event/1 #1380

Closed zacck-zz closed 6 years ago

zacck-zz commented 6 years ago

What's in this PR?

Adding test coverage for the GitHub.Sync.installation_event/1

References

Fixes #1373

Progress on: #

zacck-zz commented 6 years ago

Struggling to test some validation clauses, however, seeking some help testing for the following clauses

{:error, :validating_github_issue, Changeset.t()}
{:error, :validating_user, Changeset.t()}
{:error, :multiple_issue_users_match}
zacck-zz commented 6 years ago

Ok done!!

zacck-zz commented 6 years ago

@begedin ok ✂️ done!

begedin commented 6 years ago

@zacck As usual, thank you for your time, work and expertise. 👍