search

code-for-portland-archive / codeforportland.github.io

The Code for Portland website.
http://codeforportland.org
MIT License
4 stars 4 forks source link

fix broken images, run grunt deploy #13

Closed ungoldman closed 10 years ago

ungoldman commented 10 years ago

Noticed some broken images once the site was deployed, so I fixed those and ran grunt deploy to update production assets as well.

elauervose commented 10 years ago

Doesn't that happen in travis CI?

ungoldman commented 10 years ago

@elauervose Looking at the .travis.yml file, Travis CI tries to run bundle exec grunt deploy, which I don't think would work quite right since grunt is not a Ruby utility but a Node utility, and bundle exec is a method for running gem commands within the context of an installed bundle of Ruby gems.

Long story short, even if Travis is running grunt deploy, it's only running it locally on the Travis server when testing. @fardog set up grunt deploy to minify bower components and other assets for production, so if anything in the _src/ CSS or JS changes, grunt deploy needs to be run to build those into the assets folder.

Even shorter version: we should simplify our site tooling and deploy process to make contributions easier.