code-iai / iai_maps

The semantic and ground lab and environment maps for projects in the IAI group in the University of Bremen
12 stars 37 forks source link

Kitchen washer fridge #67

Closed Tigul closed 4 years ago

Tigul commented 4 years ago

Added

Fridge

Dish washer

gaya- commented 4 years ago
  1. rename fridge_door_shelve into fridge_door_shelf
  2. clarify the necessity to comment out the simulated flag stuff
ichumuh commented 4 years ago

That doesn't seem right? Screenshot from 2020-02-05 11-02-17

gaya- commented 4 years ago

@ichumuh could it be that we changed the pose of the handle because the mesh did not correspond to the real world? It doesn't look like Jonas did anything in his commits to break the pose of the handle.

ichumuh commented 4 years ago

@gaya- yes could be. I just measured to make sure. The real distance between handle and hinge is 9cm, which creates this hole. This means that the position was correct, but the handle mesh is too short and the door is too thin. @Tigul please revert the last commit and then I'll merge.

gaya- commented 4 years ago

@ichumuh I think @Tigul will not be working tomorrow, so if you want this PR earlier you can always revert stuff yourself after merging ;)

Tigul commented 4 years ago

@ichumuh I reverted the change to the handle position.

ichumuh commented 4 years ago

thanks