search

code-iai / iai_maps

The semantic and ground lab and environment maps for projects in the IAI group in the University of Bremen
12 stars 37 forks source link

Update room.urdf.xacro for noetic #88

Closed artnie closed 2 years ago

artnie commented 2 years ago

...and the other xacro files in iai_kitchen_defs as well. Adds xacro prefixes to all native and custom macros within iai_kitchen_defs. This is needed for urobosim. The kitchen's urdf is untouched by this PR, it will be covered in a separate PR.

I didn't see any launch file use the xacros in iai_kitchen_defs except for iai_maps/launch/room.launch.

I tested this PR by comparing the old room in melodic with this new one in noetic, they look the same. But the walls around the kitchen (where the tables are on which we put our laptops and work and stuff) are outdated and need to be moved. Changing any parameters is not part of this PR though.

artnie commented 2 years ago

Thank you, Michael, for taking care of the review!

artnie commented 2 years ago

@sunava or @hawkina could you checkthe two latest commits in this pr? They change the urdf_obj xacro files such that the visual meshes use the .dae files instead of .obj. The launchfiles use the latest updated version of iai_kitchen_python.urdf.xacro

Shouldve opened a new PR for that but accidentally pushed to the existing one, sorry.