search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Images added via GitHub are not rendered properly #100

Closed jwngr closed 1 year ago

jwngr commented 1 year ago

Repro steps:

  1. Create a PR from GitHub
  2. Add any image
  3. Submit PR

Expected: CodeApprove displays that image properly

Actual: CodeApprove displays broken images (see below)

Screenshots

Screenshot - 2023-05-31 at 11-47-23@2x Screenshot - 2023-05-31 at 11-45-18@2x Screenshot - 2023-05-31 at 11-45-23@2x
samatcodeapprove commented 1 year ago

@jwngr thanks for reporting this. Seems like GitHub has changed their image URLs? IIRC they used to be on githubusercontent.com but now they seem to be stored under a repo-specific path. I'll dig.

Edit Ah yeah confirmed, GitHub made a breaking change here: https://github.blog/changelog/2023-05-09-more-secure-private-attachments/

samatcodeapprove commented 1 year ago

@jwngr this is now fixed, although what I did was a bit of a hack (GitHub did not think this change through, IMO) so I am not 100% sure it will keep working forever! Definitely flag if you see anything broken like this in the future.

jwngr commented 1 year ago

Seems to be working again - thanks!