search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

GIFs on CodeApprove don't appear on Github #105

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

We had a confusing exchange recently because one of my teammates commented on CodeApprove with a GIF:

image

But when the comment was mirrored to Github, there was no GIF or indication of a GIF:

image

So, I was confused because the comment didn't make sense without the GIF as context.

It's obviously not super important, but it would be good to either make sure the GIF translates to the Github-echo'ed comments or to indicate in the Github version that a GIF is missing from the comment.

samatcodeapprove commented 1 year ago

@mtlynch uhhh in what world is a hackerman gif not important? P0!

(but really, I would expect this to work and I don't think it'll be a hard fix)

mtlynch commented 1 year ago

Haha, thanks, @samatcodeapprove I appreciate it!

samatcodeapprove commented 1 year ago

@mtlynch actually I think this was somehow specific to that GIF! Here's a test I did directly on GitHub: https://github.com/codeapprove/meta/issues/35

That Hackerman gif does not render, but the (excellent) gif of the Raptors mascot falling renders fine with very similar markup.

GitHub does some weird things to the Markdown and generates an <animated-image> tag where the Hackerman gif points to this URL: https://camo.githubusercontent.com/a477b27ff52cb1d20777fad6cbfd6810b979008ca84439c9c0ea0d8ce2916dcd/68747470733a2f2f692e696d6775722e636f6d2f706c4a476e43622e676966

When I click that URL I get "Content Length Exceeded". I'll report this to GitHub but I don't think there's much more I can do!

mtlynch commented 1 year ago

Ah, thanks for checking into it!