codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Comments disappear after force push and "Reveal All" doesn't work #106

Open samatcodeapprove opened 1 year ago

samatcodeapprove commented 1 year ago

Originally reported by @mikelehen over email, reposting here:

My workflow for sending a PR for review is basically:

Create the PR.

Go through the diffs in CodeApprove and:

Add comments to help the reviewer understand any non-obvious changes.

Fix minor issues I notice in the code, amend my commit (for cleaner history), and force push the updated changes.

The problem is that when I force-push my changes, my draft comments in CodeApprove disappear from the file diffs (though they still show in the bottom list of comments, sometimes marked as outdated).

The file will often (but not always?) show a "Warning: some comments in this file are on non-loaded lines" at the top, but clicking the "Reveal All" button does not reveal the comments. So the reviewer won't see them.

Arguably force pushes aren't the best practice, but I think it's fine until I actually send the PR out for review. And Github's builtin code review tooling handles this fine, though admittedly I don't know exactly how it does it.

It would be great if CodeApprove handled this as well as Github!