search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Github File/Line Comments #107

Open ianb-pomelo opened 9 months ago

ianb-pomelo commented 9 months ago

People at our company use a couple different code review tools depending on their preference/prior experience. A couple of us used to work at Google and miss Critque (so CodeApprove is great!) but since we won't have everyone use it due to a preference for the Github UI, we would need to make interop between CodeApprove and the Github UI pretty seamless.

After testing things out, I can't find a way to leave line-level or file-level comments in CodeApprove that are written in Github as line/file level comments. Is this possible?

samatcodeapprove commented 7 months ago

@ianb-pomelo sorry I never answered you here, this somehow slipped past my Gmail filters. Right now this is not possible because CodeApprove comments are not 1:1 compatible with GitHub. For example in CodeApprove you can comment on any line, not just lines in the diff. GitHub does not allow this.

However you're not the first one to ask for a "GitHub transparency mode" where features like that would be restricted in order to create greater compatibility. This is something I'd like to work on soon.