search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

CodeApprove badge not appearing on a PR #108

Closed mtlynch closed 6 months ago

mtlynch commented 7 months ago

We're having trouble getting CodeApprove to add a badge on a private repo PR:

https://github.com/tiny-pilot/microsd-integrity-check/pull/30

I tried disabling / re-adding the repo to the CodeApprove Github app, but it didn't seem to have an effect. I also tried adding the label codeapprove, but no effect.

I am able to construct the CodeApprove review URL manually:

https://codeapprove.com/pr/tiny-pilot/microsd-integrity-check/30

jotaen4tinypilot commented 7 months ago

Some more data points here:

I tried to manually construct the review URL manually before (https://codeapprove.com/pr/tiny-pilot/microsd-integrity-check/30), but that resulted in a 404. In contrast to @mtlynch, I don’t have admin permissions on the repo, however, so it may have to do something with this?

I can reproduce the 404 in another PR (#28) of that same repo, which also misses the badge. So when going to https://codeapprove.com/pr/tiny-pilot/microsd-integrity-check/28, I get a redirect to https://codeapprove.com/404.

jotaen4tinypilot commented 7 months ago

I was able to produce a link by adding the codeapprove label to the PR beforehand (manually). So without that label, I got the 404. After adding the label, it worked. The badge button (“Review on CodeApprove”) was automatically added after I added the codeapprove label.

mtlynch commented 7 months ago

@samatcodeapprove - Any updates here? We're still seeing this issue.

samatcodeapprove commented 7 months ago

@mtlynch sorry somehow this issue slipped past my Gmail filters, I will take a look!

samatcodeapprove commented 7 months ago

@mtlynch @jotaen4tinypilot in Settings for the repo in question do you have the auto-create reviews setting enabled?

Screenshot 2024-02-14 at 8 33 26 PM

From what I can see in the database you have that setting enabled on many of your repos, but not the one we're talking about here (microsd-integrity-check).

Without that setting, the review is only created when the codeapprove label is manually added on GitHub.

(Btw: to navigate to a CodeAppove review directly from GitHUb you can just replace github.com with codeapprove.com in your URL bar and everything should work)

mtlynch commented 7 months ago

@samatcodeapprove - Ah, it was off. Thanks!

Is it off by default when adding a repo? I don't recall disabling it, and my expectation is that the setting would be enabled by default.

samatcodeapprove commented 7 months ago

Yeah it's off by default right now, because for new users the ability to try CodeApprove one PR at a time makes onboarding low risk.

I'm happy to make this an org-wide setting so that you can set it and forget it though.

mtlynch commented 7 months ago

I'm happy to make this an org-wide setting so that you can set it and forget it though.

That would be handy!

samatcodeapprove commented 6 months ago

Deploying a new version of the Settings page now which allows the "auto review" setting to be enabled at the org level.

mtlynch commented 6 months ago

@samatcodeapprove - Excellent, thanks!