search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Line preview is illegible in dark mode #110

Closed mtlynch closed 7 months ago

mtlynch commented 7 months ago

Thanks for adding light mode (#96)!

I think a small side-effect is that the line preview is mostly illegilble in dark mode:

image

samatcodeapprove commented 7 months ago

@mtlynch thanks for filing this! Seems like an issue with how code themes are loading in dark mode in production, not happening in development. I will take a look.

samatcodeapprove commented 7 months ago

@mtlynch ok the general issue with theme loading should be fixed now! It was a Webpack thing. Still don't love how those single-line previews look in light mode but it's a lot better.

mtlynch commented 7 months ago

@samatcodeapprove - Fix confirmed. Thanks!