Feature request: Support ``suggestions`` and links to specific lines

adlrocha commented 1 month ago

Hey, Sam. @adlrocha from Finiseterra Labs here. I wanted to kick-off my first feature request letting you know what I guess Henrique has put forward already, but we love your product :heart_eyes: Amazing job!

I was wondering how hard would it be to add a few features that I was used to use extensively in GH but don't seem to be available in Code Approve:

It would be great if we could select a line of the code and use the suggestions tag in the comment. It doesn't need to prompt the "commit suggestion" or "add to batch" buttons like in GH, it can behave like the markdown diff block, but I think it can be really useful to show the original code of the line selected and the suggested change.
Also, I am really missing the ability to select a line and share a link to that line as part of my comment. Every time I want to reference a specific line from my reviews I need to jump to the PR in GH, copy the link, and share it as part of my CodeApprove comment.

Let me know if this is clear, happy to do a follow-up. Also feel free to completely disregard my requests if they are not feasible or too specific. Thanks!

samatcodeapprove commented 1 month ago

@adlrocha thanks for the feedback! Both ideas make sense and should be at least partially feasible.

For the link to line feature can you give me an example of what those links look like on GitHub today so I get it right? And would you want the links to go to GitHub or to CodeApprove?

adlrocha commented 1 month ago

This is an example of a multi-line link to some code in a PR in GH: https://github.com/libp2p/go-smart-record/pull/24/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R31-R33

Ideally it would be useful for the links to jump to those lines in CodeApprove if possible, so that someone reading a comment with the link can jump directly to those lines in the review. :pray:

samatcodeapprove commented 3 weeks ago

@adlrocha thanks for the example, sorry for my slow response. I'm working on a link-to-line feature now and it will hopefully be done this week.

After that I'll check out suggestions, although I'm not quite sure how I'd want that to work yet.

samatcodeapprove commented 3 weeks ago

@adlrocha just deployed the "link to line numbers" feature! Here's a video of it in action: https://www.loom.com/share/1194da2366984f8797867ef7bf07923f

If you have any feedback or if that's not what you had in mind, just let me know.

adlrocha commented 3 weeks ago

This is amazing, @samatcodeapprove, thank you! It works like a charm!

Btw, no rush with the suggestions feature, and let me know if I can help you with anything there. Cheers.

codeapprove / feedback

Feature request: Support ``suggestions`` and links to specific lines #117