search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Opening a PR triggers a notification #25

Closed mtlynch closed 2 years ago

mtlynch commented 2 years ago

CodeApprove generates a bit of email/notification noise because it adds a comment to a PR announcing that the PR:

image

If you have email notifications enabled, it means an extra email to everyone on the PR which isn't actionable, as CodeApprove being available doesn't necessarily make the PR ready for review. If CodeApprove is configured to add itself to every PR in a repo, it means getting an extra notification as soon as the PR opens.

My preference would be for CodeApprove to just edit the top-level comment with a link rather than adding its own comment and triggering a notification.

samatcodeapprove commented 2 years ago

@mtlynch I love the idea of editing the PR description instead! Thanks for the tip, I’ll probably do that.

samatcodeapprove commented 2 years ago

@mtlynch rolling this out now. You should see this fun new badge at the bottom of your PR description as soon as the PR is added to CodeApprove:

github-tag-allbg

mtlynch commented 2 years ago

Looks great! Thanks!