search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

CodeApprove elides single lines in diff #28

Open mtlynch opened 2 years ago

mtlynch commented 2 years ago

I ran into a situation where CodeApprove elided a single line of code:

image

This is a little silly because in the space it took to elide the line, it could have just rendered the line.

samatcodeapprove commented 2 years ago

Yeah that's definitely not great. RIght now CodeApprove gets the initial diff directly from GitHub and GH sometimes makes strange decisions about where chunk boundaries are. But I can probably add an enhancement on my side to detect very small chunks and automatically expand them without user interaction.