Open mtlynch opened 2 years ago
@mtlynch thanks for the super clear example here! CodeApprove and GitHub use identical diffs at the moment (although with some differences in sub-line highlights) so it's good to know where other tools are doing better.
I ran into an instance where Reviewable and CodeApprove produce slightly different diffs and wanted to share it.
Full diff in patch format: https://patch-diff.githubusercontent.com/raw/tiny-pilot/tinypilot/pull/1043.patch
Before
After
The lines that don't change are:
Github & CodeApprove
Github and CodeApprove perform about the same, viewing almost every line as changing:
Reviewable
Reviewable manages to perform a little better, as it recognizes that the
import flask
line is unchanged, though it still marks theclass VersionFileError(Error):
line as having changed:It also does character-level diffing on the symbol names, although I don't think that's obviously better than word-level diffing in this context.