search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Copying code from CodeApprove adds extraneous line breaks #56

Open mtlynch opened 1 year ago

mtlynch commented 1 year ago

If I copy the following code from a CodeApprove diff:

  pip:
    # Ensure cryptography is installed into the global Python environment, even
    # when Ansible is running from within a Python virtual environment.

When I paste the text, it has extra newlines:

  pip:

    # Ensure cryptography is installed into the global Python environment, even

    # when Ansible is running from within a Python virtual environment.
samatcodeapprove commented 1 year ago

This bug is fixed in today's release.

mtlynch commented 1 year ago

@samatcodeapprove - I'm still seeing the extra newlines.

I'm on a Windows 10 system if that matters. But for example, on this PR: https://codeapprove.com/pr/tiny-pilot/tinypilot/1296?head=86fae61abb9502fe87d487c6f9da5abd7416c272

Any lines I copy, when I paste them to Notepad or VS Code, I see extra newlines on every line.

samatcodeapprove commented 1 year ago

Ah the Windows part may actually matter (since we’re dealing with newlines)! I’ve got a Windows machine I can test on.

On Tue, Feb 28, 2023 at 10:00 PM Michael Lynch @.***> wrote:

@samatcodeapprove https://github.com/samatcodeapprove - I'm still seeing the extra newlines.

I'm on a Windows 10 system if that matters. But for example, on this PR: https://codeapprove.com/pr/tiny-pilot/tinypilot/1296?head=86fae61abb9502fe87d487c6f9da5abd7416c272

Any lines I copy, when I paste them to Notepad or VS Code, I see extra newlines on every line.

— Reply to this email directly, view it on GitHub https://github.com/codeapprove/feedback/issues/56#issuecomment-1449397180, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2GUM4FACKBMGX2CMIMDY6LWZ3QXPANCNFSM6AAAAAAQGGE27Y . You are receiving this because you were mentioned.Message ID: @.***>