search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Non-existing “file” appears in CodeApprove review #75

Closed jotaen4tinypilot closed 1 year ago

jotaen4tinypilot commented 1 year ago

In this PR https://github.com/tiny-pilot/tinypilot/pull/1161, Github shows 9 files changed:

Screenshot 2022-10-21 at 17 22 23

On CodeApprove, however, there is a tenth file, that reports a filename change of a non-existing file. Instead, the “file name” is a seemingly random piece of text from the change set:

Screenshot 2022-10-21 at 17 21 33
samatcodeapprove commented 1 year ago

@jotaen4tinypilot whoah that's really really strange, I have never seen the diff parser have an issue like that before. Thanks for flagging the specific PR

samatcodeapprove commented 1 year ago

A fix for this issue has been released, I had to upgrade our diff parser library.

TIL that python comments (---) look a lot like diff headers (+++, ---)!