search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Allow comments on binary files #76

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

I'm reviewing a PR that includes image files. CodeApprove allows me to mark the image file as reviewed, but it doesn't allow me to attach comments to the file. I'd like to be able to comment on binary files sometimes, especially images and videos.

I don't need anything fancy like commenting on a particular part of the image/video. Just being able to make file-level comments would be sufficient.

samatcodeapprove commented 1 year ago

Thanks for requesting this! This has been a long-awaited feature request but I forgot to migrate it to GitHub

samatcodeapprove commented 1 year ago

You can now leave comments on whole files, including images and other binary files! https://www.loom.com/share/fb18cae8f9a6437184b6fa1130ef2c17

mtlynch commented 1 year ago

Awesome, that looks great. Thanks for adding this!