search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Confusing commit select order #78

Closed tstirrat closed 1 year ago

tstirrat commented 1 year ago

Showing the commits in reverse order on the second commit selector always confuses me.

Screen Shot 2022-10-29 at 6 52 56 AM

Suggestion:

Fade out the omitted commits, always use the same order:

Screen Shot 2022-10-29 at 7 00 27 AM

If you did this on both selectors, it would still be a huge benefit.

💡 Future: Ideally you could make it a single dropdown with 2 clicks setting the from and 2 respectively, but I think the above order and visual changes will drastically improve the UX and is much less work.

tstirrat commented 1 year ago

Quick 1 min idea: You could even add a little left border or faint blue background that moves as you hover over the end to show this is an inclusive selection.

Screen Shot 2022-10-29 at 7 12 59 AM Screen Shot 2022-10-29 at 7 14 58 AM
samatcodeapprove commented 1 year ago

@tstirrat you are a legend! These designs are really nice and they're inspiring me to do something about this UI.

samatcodeapprove commented 1 year ago

Note to self, this is very overlapping with https://github.com/codeapprove/feedback/issues/70

samatcodeapprove commented 1 year ago

About to deploy some improvements here, incorporating a lot of your ideas. Here's a preview: https://www.loom.com/share/945b3e87942f456fbd8d0dc49b1f0246

tstirrat commented 1 year ago

Omg yes! Looks great!

On Sat Feb 25, 2023, 09:07 PM GMT, Sam Stern @.***> wrote:

Closed #78 https://github.com/codeapprove/feedback/issues/78 as completed. — Reply to this email directly, view it on GitHub https://github.com/codeapprove/feedback/issues/78#event-8608531598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLUDSHHZ3OR5VF4QLSS7TWZJX7TANCNFSM6AAAAAARRMFALA. You are receiving this because you were mentioned.Message ID: @.***>