CodeApprove can't see a private repo, even though it's visible in settings

codeapprove / feedback

Feedback for CodeApprove

0 stars 0 forks source link

CodeApprove can't see a private repo, even though it's visible in settings #81

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

I have a private repo I've configured to use with CodeApprove:

We recently created a PR, and CodeApprove added the proper label:

But it didn't update the PR description with a CodeApprove badge, and attempting to view the PR from CodeApprove fails:

samatcodeapprove commented 1 year ago

Yikes that's not good, I will do some digging but in the meantime you might want to try "turning it off and back on again":

Sign in/out of CodeApprove
Remove/re-add the repo through your CodeApprove settings

samatcodeapprove commented 1 year ago

@mtlynch actually before you try those nuclear options, does removing and re-adding the label to the PR work? As far as I can tell CodeApprove has no problem connecting to this repo (I see PRs 116 through 139) but 140 seems to be missing.

mtlynch commented 1 year ago

@samatcodeapprove - Ah, removing and re-adding the label fixed it. Nothing in the logs about PR 140 before that?

samatcodeapprove commented 1 year ago

@mtlynch unfortunately this escaped my logging, it must have failed very early (or not reached me at all, but that feels unlikely). I have spent the night beefing up logging at the root level to catch this in the future!

Going to close for now since I can't actually investigate this with the data I have.

mtlynch commented 1 year ago

@samatcodeapprove - This happened again on a public repo, though this time the label didn't get added at all:

https://github.com/tiny-pilot/tinypilot/pull/1198