search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Bug? Cannot submit comments #83

Open jotaen4tinypilot opened 1 year ago

jotaen4tinypilot commented 1 year ago

When trying to review https://github.com/tiny-pilot/tinypilot/issues/1191 / https://codeapprove.com/pr/tiny-pilot/tinypilot/1231, I seem to not be able to submit my comments – at least I’m not sure about it, because they don’t show up on Github. The Review Log on the right hand side also shows a bunch of seemingly empty entries. I tried to submit my comments a few times.

https://user-images.githubusercontent.com/83721279/207891258-b94cb2e8-91ef-4dc9-b383-1f4dda711208.mov

(Sorry for the low resolution, Github unfortunately only allows uploads <10M)

Here is the JS console output:

Screenshot 2022-12-15 at 15 42 01
jotaen4tinypilot commented 1 year ago

Update: the comment showed up on Github in the meantime.

samatcodeapprove commented 1 year ago

@jotaen4tinypilot yikes that is not good! Has this issue gone away or is it still happening? And is it limited to one review or is this happening to you across all PRs?

jotaen4tinypilot commented 1 year ago

I think it only happened in this very instance. Since the comment showed up afterwards, it almost felt as if the submission was temporarily stuck in a queue or so, while the CodeApprove UI suggested it went through successfully, and didn’t give any indication that it wasn’t actually fully processed yet. That way, I intuitively assumed that the submission had failed altogether, and re-submitted multiple times.

In any event, I just tried again on a different review, where I first submitted my comments as “Comment” (like yesterday), and then submitted as “Approval”. Here, it all worked as expected again.