search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

CodeApprove can't render "Since my last review" #85

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

I've run into an odd scenario in CodeApprove where it seems confused about the ordering of reviews and commits.

https://codeapprove.com/pr/tiny-pilot/tinypilotkvm.com/881

Here are the commits:

image

I gave my last review on this PR in CodeApprove on 2022-12-20 after commit 5e1120d. CodeApprove shows the correct time for this review:

image

In CodeApprove, if I select "Show: Since my last review", it sets both the base and head to 5e1120d even though 5e1120d was on 2022-12-20 @ 3:20 PM EST:

image

I'd expect CodeApprove to set base to 5e1120d and head to dfdbcae since dfdbcae is the only commit that occurred after my last review. If I manually choose those commits, it shows the expected result, but for some reason, CodeApprove can't figure out the correct diff to show.

samatcodeapprove commented 1 year ago

@mtlynch thanks for reporting this, I will take a look.

samatcodeapprove commented 1 year ago

Ok I think I found the fix here, pushing this. It's a little hard to be 100% sure (since I don't have the ability to time-travel debug and see what you saw at that exact moment) so let me know if anything like this happens again!

mtlynch commented 1 year ago

Thanks!