search

codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Trigger warning for unsaved edits before submitting review #86

Open jotaen4tinypilot opened 1 year ago

jotaen4tinypilot commented 1 year ago

After adding my comments for a review, I usually read over them again and often make some edits here and there to the comment copy, before submitting the review. Especially when the comment text boxes are toggled to preview mode, it’s easy to miss that a text change wasn’t saved yet. For me, it appears that if there are pending, unsaved comment changes, you can still submit the review, in which case it takes over the previous comment, not the unsaved, in-flight edit. (This happens regardless of whether the comment is rendered in preview-mode or not, though.)

It would be cool if CodeApprove would trigger a warning before accepting the review, to warn users that some of the comments have unsaved changes. Otherwise you might accidentally submit a potentially outdated version of the comment copy.

samatcodeapprove commented 1 year ago

@jotaen4tinypilot thanks for this feedback! I agree, this would be a nice improvement.