codeapprove / feedback

Feedback for CodeApprove
0 stars 0 forks source link

Style: Reduce margins for sub-lists #95

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

To me, lists within lists have an awkward amount of y-axis padding:

image

Would you consider a rule like this?

li ul {
  margin-top: 0;
  margin-bottom: 0;
}

That should result in lists that look like this:

image

samatcodeapprove commented 1 year ago

Sounds like a quick win to me! Will do.

On Fri, Apr 14, 2023 at 11:00 AM Michael Lynch @.***> wrote:

To me, lists within lists have an awkward amount of y-axis padding:

[image: image] https://user-images.githubusercontent.com/7783288/232121521-5dd55fb2-6cf3-4d49-99a5-efdd597f4958.png

Would you consider a rule like this?

li ul { margin-top: 0; margin-bottom: 0; }

That should result in lists that look like this:

[image: image] https://user-images.githubusercontent.com/7783288/232121929-e385db23-7815-4dc9-8982-9a6b047ccc6a.png

— Reply to this email directly, view it on GitHub https://github.com/codeapprove/feedback/issues/95, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2GUM4HZPTIYENOTRHUW3FLXBGGD3ANCNFSM6AAAAAAW6XCFSU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

samatcodeapprove commented 1 year ago

Deploying an adjustment here now, spacing should be much tighter.

mtlynch commented 1 year ago

Cool, I like this spacing. Thanks!