Open source files with utf-8-sig encoding

codeclimate / python-test-reporter

DEPRECATED Uploads Python test coverage data to Code Climate

https://codeclimate.com

Other

19 stars 11 forks source link

Open source files with utf-8-sig encoding #21

Closed dblandin closed 8 years ago

dblandin commented 8 years ago

Files encoded with BOM signatures need a bit more care when they're read and later encoded with utf-8. This PR updates the read call to use the utf-8-sig encoding to adjust for these BOM signatures.

@codeclimate/review :mag_right:

gdiggs commented 8 years ago

LGTM - do we have any test coverage that we could improve here?

pbrisbin commented 8 years ago

One minor thought. LGTM either way.

dblandin commented 8 years ago

LGTM - do we have any test coverage that we could improve here?

@GordonDiggs I haven't had much luck updating the test fixture with a BOM signature, causing tests to fail. I've also had trouble reproducing the error locally using known repos that have encountered the error described in #20.

So I'm hoping this works.