search

codeclimate / python-test-reporter

DEPRECATED Uploads Python test coverage data to Code Climate
https://codeclimate.com
Other
19 stars 11 forks source link

clarify usage of coverage generators #27

Closed djetelina closed 8 years ago

djetelina commented 8 years ago

It took me about two days to realize that --cov=codeclimate_test_reporter isn't supposed to be there in my case, that it's not a magical plugin that gets and sends that report, that it's just the part you want to cover. I'd generally avoid using codeclimate_test_reporter as an example, as it can be confused. If you want a specific example, why not use an existing library that's not self? :)

pbrisbin commented 8 years ago

That makes sense to me. @dblandin any reason not to merge?

dblandin commented 8 years ago

Nope. This makes sense to me! Pretty sure I was dogfooding the reporter during development and just used my own invocations for the README examples, which I can see now is confusing.

Thanks @iScrE4m!

pbrisbin commented 8 years ago

I've confirmed that the test error is because ENV vars aren't available in PRs for outside contributions. So I'm going to merge around it.