search

codeforamerica / cfapi

The Code for America API. Tracks and motivates activity and participation across the civic technology movement.
http://codeforamerica.org/api
MIT License
113 stars 52 forks source link

Add `logo_url` to Organization API response #322

Closed tdooner closed 6 years ago

tdooner commented 6 years ago

This adds a new field to the Organization API response that contains a URL to a logo for that organization. Currently this is only pulled from the GitHub projects_list_url, which is not the be-all-end-all for a couple reasons:

1- It's hard to tell if an organization has uploaded a logo or if github generated them a default blocky logo.

2- Some organizations use a CSV file for their projects_list_url.

In the case of 1, we will currently use the placeholder logo. In the case of 2, the logo_url will be null. This adds support for, but I have not tested, a "logo_url" key/value in the brigade-information organizations.json file also, for any brigades that wish to override this with a custom image.

tdooner commented 6 years ago

Having addressed Andrew's feedback, gonna merge this and watch it run this afternoon.