search

codeforbtv / cvoeo-app

The "Money on My Mind" app helps CVOEO's Reach-Up clients stay on track with their personal finance coaching.
Apache License 2.0
11 stars 4 forks source link

fixed upgrade issues #47

Closed johnneed closed 5 years ago

johnneed commented 5 years ago

Fixed upgrade issues. App now builds and runs. You should nuke node_modules and then run yarn

doub1ejack commented 5 years ago

@jbpayne I want you to have a chance to read all the resolved comments in this PR. I think they'll be helpful to you.

When you're done, would you give an approving review and merge this PR?

doub1ejack commented 5 years ago

I pulled & ran this PR and it does fix the babel 6 vs 7 issue for me. There are some alerts and warnings, but I don't think they are related to this PR:

doub1ejack commented 5 years ago

It looks like @jbpayne has had a chance to look at these comments, so I'll fix the package-lock.json conflict and just go ahead & merge this PR.

johnneed commented 5 years ago

I wouldn't fix those conflicts. package-lock.json is an auto-gen file. Just delete it. Having said that, we shouldn't have a package-lock.json file. It's an artifact of npm. Yarn works much better with Expo because it has better linking. yarn-lock.json is the lock file for yarn.