search

codeforbtv / cvoeo-app

The "Money on My Mind" app helps CVOEO's Reach-Up clients stay on track with their personal finance coaching.
Apache License 2.0
11 stars 4 forks source link

Fix problem with Logout circle on Android #96

Open jfenner opened 5 years ago

jfenner commented 5 years ago

The Logout circle has been implemented from the ellipsis menu and works fine on iOS. However, on Android the area below the top header does not accept touch responses. The short-term fix has been to move the "Log out" text up to the header area, but a solution that fixes the menu so it works correctly should be explored.

Relates to issue #94

johnneed commented 5 years ago

Tested in this GenyMotion using a Google Pixel 2 emulator. It seems to work fine. @jfenner @jbpayne or @jfenner can one of you confirm that this ticket is complete? image

jbpayne commented 5 years ago

There was a workaround implemented here because the touchable area on android doesn't extend below a certain point, so the original location of the logout text didn't work. I moved it up so that it will work for now, but we were planning to come back to it and research the problem.

If you have an idea what the problem is and can fix it, that would be great, or if you think the workaround is good enough to close the issue, then that would be great, too.

johnneed commented 5 years ago

@jbpayne

If logout is the only menu option, I'd make the ellipse itself the logout button. Of course you'll need to change the icon.

removing the whole circular menu would greatly simplify things. You can always add it back later if you need to add menu items.

doub1ejack commented 5 years ago

@jfenner, @jbpayne, @johnneed - can anyone say what a reasonable solution would be? John Need suggested:

"I'd make the ellipse itself the logout button"

Is that a viable solution? (I'm assuming this remains an issue since I've only tested on iOS so far..)

jfenner commented 5 years ago

If we remove the animation for the expanding circle, you could just make the ellipse the logout and popup the "Are you sure you want to logout?" dialog. Just depends on if there is going to be any other options for the ellipse menu in the future.

Jon

On Mon, Sep 9, 2019 at 10:56 PM Micah Mutrux notifications@github.com wrote:

@jfenner https://github.com/jfenner, @jbpayne https://github.com/jbpayne, @johnneed https://github.com/johnneed - can anyone say what a reasonable solution would be? John Need suggested:

"I'd make the ellipse itself the logout button"

Is that a viable solution? (I'm assuming this remains an issue since I've only tested on iOS so far..)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforbtv/cvoeo-app/issues/96?email_source=notifications&email_token=ABH62I3EPVXF3A6N2AAHCSDQI4EEJA5CNFSM4IJWLTVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JUZTA#issuecomment-529747148, or mute the thread https://github.com/notifications/unsubscribe-auth/ABH62I5T7WSXTWLU4QOATHLQI4EEJANCNFSM4IJWLTVA .

-- Jon Fenner Principal Consultant

AuraQuest, Inc. (http://www.auraquest.com) 802-310-5909 mobile