search

codemonauts / craft-instagram-feed

Craft CMS plugin to receive Instragram feed data as variable in templates
MIT License
28 stars 8 forks source link

Implement file_get_contents timeout #12

Closed mikehayesuk closed 5 years ago

mikehayesuk commented 5 years ago

I think it makes sense to maintain a reasonably low timeout to avoid the possibility of page hangs in the event that Instagram is offline.

I know a global timeout can be set in the PHP configuration but this should offer a good safety net regardless of configuration. Personally I would use a lower timeout, more like 1 second, but again this offers a good safety net - perhaps in future the timeout could be configurable.

kringkaste commented 5 years ago

Hey @mhayes14, thanks for your contribution. We will make the timeout length customizable in the config file.