search

codetech / codetechcomputerclub

codeTech Computer Club's website.
MIT License
4 stars 1 forks source link

Move location of action buttons. #8

Open jonjmz opened 10 years ago

jonjmz commented 10 years ago

Move all action buttons from the bottom of the page i.e. the one in the projects page to the sidebar. The session, and auth flash has already been moved to the sidebar, except when not logging in because the wrong username/password combination was used.

The sidebar is a more logical place to place action then the main page.

Move the login details out of the sidebar and into the header.

jacksonrayhamilton commented 10 years ago

Any changes to the layout, if any (perhaps moving the login into the header) must remain compatible with all of the layout's breakpoints (mobile, 1000px-wide, etc).

The website uses skelJS to manage its breakpoints, so make sure to conform to its conventions.

Also we do not want to stuff too many things into the sidebar; I'm fine with the actions for a page being at the top of the sidebar, but I would prefer if session flash messages be displayed in a banner at the top of a page. Preferably color-coded too, green for success, light red for failure, and grey for permission denied.

jonjmz commented 10 years ago

OK, I agree with a lot of what you say. At this point every change has been checked in all three screen modes, and looks fine, with the exception of flash messages displaying bellow the content on phones. This enough makes it worth moving them back. As they were before the change they took too much of the vertical space when displayed. I will return them to their previous location, and style them out of prominence (probably by reducing the vertical margins, and coloring them in light pastels. I'm still not sure how to gracefully move the session info to the headers, but will work on that.