codingteam / loglist

Reincarnation of the famous service
https://loglist.xyz/
MIT License
7 stars 4 forks source link

Update Scala.js #186

Open ForNeVeR opened 7 years ago

ForNeVeR commented 7 years ago

This is surprisingly complex task until we've done migration from Play framework. I have done some initial work in feature/frontend, but currently I cannot build it with fullOptJS because of some Play+RhinoJS inconsistencies. Maybe we'll revisit this branch later.

rexim commented 7 years ago

I'd say that it's kind of extracted from #185

ForNeVeR commented 7 years ago

That's another approach to #161 I've tried before creating #185. Now it's a separate task.

hagane commented 7 years ago

@ForNeVeR I would like to help. Could you elaborate on the issues you encountered? And on the rationale behind the whole "migration from Play" thing, for that matter -- looks like there's no outstanding issues regarding it.

ForNeVeR commented 7 years ago

There're no issues, but the whole milestone full of various ideas. Maybe it'd be better to first come up with some vision of our new platform.

hagane commented 7 years ago

I'd like to respectfully ostracize the very idea of performing a near-total redevelopment of the website, especially considering that some sick bastards well-adjusted gentlepeople happen to peruse it. We have a CTOR rewrite-from-scratch in the works, how about trying the whole finagle shebang there first? It's stalling hard anyway, so the cost of eventual potential failure would be negligible.

ForNeVeR commented 7 years ago

We have a CTOR rewrite-from-scratch in the works, how about trying the whole finagle shebang there first?

That's why nobody is rewriting loglist actively. Wanna to participate? You're welcome. Wanna criticize? You're welcome in the corresponding issues.

Regarding Scala.js — tomorrow at the morning I'll describe the exact issue I was having while trying to enable fullOptJs there.

hagane commented 7 years ago

Right. Meanwhile I'll accept the invitation and go criticize.

ForNeVeR commented 7 years ago

Regarding the issue: I've rebased feature/frontend on top of the current master (i.e. after using fullOptJS in build), and now it's getting the following error:

java.lang.NoSuchMethodError: com.google.javascript.rhino.Node.setStaticSourceFile(Lcom/google/javascript/rhino/StaticSourceFile;)V

I have no exact idea what's happening there, but I have a suspicion that it have something to do with the installed Rhino and/or Play versions.

ForNeVeR commented 7 years ago

See #187.

hagane commented 7 years ago

I've come to conclusion that the primary cause is that org.scala-js:sbt-scalajs migrated from org.mozilla:rhino to io.apogee:rhino somewhere in 0.6.x. But org.mozilla:rhino is still transitively pulled by com.typesafe.play:sbt-plugin So far I've been able to persuade sbt to use one single version of Rhino, but the build still fails with the same error with any one of them.

The solutions still untried are:

ForNeVeR commented 7 years ago

I'd start from updating Play.

Minoru commented 3 years ago

This is superseded by #225, which updates Scala.js to 1.2.0 (amongst other things).

Minoru commented 3 years ago

Wait, I thought I'm closing the PR that tried to update Scala.js >_< Reopen, reopen until someone noticed!

Minoru commented 3 years ago

JFYI, #225 updated Scala.js to then-current 1.2.0, but the 1.3.0 is out now, so this can't be closed.