search

codingteam / loglist

Reincarnation of the famous service
https://loglist.xyz/
MIT License
7 stars 4 forks source link

Update production configs #201

Closed ForNeVeR closed 7 years ago

ForNeVeR commented 7 years ago

I've added an automatic restart for systemd and disabled the pidfile. That'll help us to restart the service in cause of any troubles such as #196 in future.

Closes #139.

Minoru commented 7 years ago

In #139 you mentioned we should create PID files in temporary storage like /tmp. Why did you decide against this? (/run is commonly used to store PID files AFAIK.)

Other than that, it looks good to me.

ForNeVeR commented 7 years ago

@Minoru I can't see any purpose for that file in our current setup. Also, storing that in /tmp wouldn't solve the problem: /tmp is cleaned only on server restart, but our current issue is that OOM Killer sometimes kills the service (without stopping the whole machine, obviously).

_(Also please note that setting pidfile to /dev/null is the documented way to get rid of it, see Play Framework docs.)_

Minoru commented 7 years ago

Ah; #139 mentions a sudden reboot, so I got confused.

Anyway, I don't see any other pragmatic solution, so I declare this good to merge.

ForNeVeR commented 7 years ago

Thanks for the review, guys!