Error catching into shell scripts

codingteam / loglist

Reincarnation of the famous service

https://loglist.xyz/

MIT License

7 stars 4 forks source link

Closed Cuttlerat closed 6 years ago

Cuttlerat commented 6 years ago

It's dangerous to not check if directory is exists.

ForNeVeR commented 6 years ago

Mr. @Minoru, could you review that, please? I'm not an expert in these matters, but I think we had similar discussion with you some time ago.

ForNeVeR commented 6 years ago

Yup, I pretty much believe that we have settled usage of set -e for the same purpose in our other website project.

Will that set -e also fix the problem with non-existent directories? I'd then vote for using set -e for consistency everywhere.

Cuttlerat commented 6 years ago

Yes, set -e would work much better and I think it's more valuable here

ForNeVeR commented 6 years ago

Could you please update your PR with set -e instead of exit 1?

ForNeVeR commented 6 years ago

Well, I'll merge that. Mr. @Minoru, feel free to comment the issue after the merge!

@Cuttlerat, thanks a lot for the contribution.