search

codingteam / loglist

Reincarnation of the famous service
https://loglist.xyz/
MIT License
7 stars 4 forks source link

Transactional DDL in evolutions #215

Closed ForNeVeR closed 6 years ago

ForNeVeR commented 6 years ago

It turned out that so-called transactional DDL support is disabled in Play evolutions by default. That's documented; to enable it, we need to set evolutions.autocommit=false.

I think that we need to do that to avoid further confusion on failed evolutions in our code base.

I have reproduced the issue #198 and checked that it won't reappear with that change: the database doesn't get changed at all if any evolution fails.

Closes #198.

ForNeVeR commented 6 years ago

It took me half a year 😆

ForNeVeR commented 6 years ago

Thanks for the review!