cognitivecomputations / spectrum

Apache License 2.0
75 stars 10 forks source link

Possible improvements to the script #5

Closed anakin87 closed 3 weeks ago

anakin87 commented 4 weeks ago

I'm taking my first steps with Spectrum. Great work!

I find it difficult to run it on notebooks, mostly because of prompt_toolkit, but I understand it is convenient, especially for weights selection.

However, I believe the script could benefit from a couple of improvements:

@Crystalcareai What do you think? If these observations make sense, I'd be more than happy to open a PR to address them.

Crystalcareai commented 3 weeks ago

wonderful suggestions, and I needed to tidy up the code anyway. All changes can be found here: https://github.com/cognitivecomputations/spectrum/pull/6

anakin87 commented 3 weeks ago

Great. Thanks!