Closed anakin87 closed 3 weeks ago
I'm taking my first steps with Spectrum. Great work!
I find it difficult to run it on notebooks, mostly because of prompt_toolkit, but I understand it is convenient, especially for weights selection.
prompt_toolkit
However, I believe the script could benefit from a couple of improvements:
if __name__ == "__main__":
self.optimizer
self.tokenizer
@Crystalcareai What do you think? If these observations make sense, I'd be more than happy to open a PR to address them.
wonderful suggestions, and I needed to tidy up the code anyway. All changes can be found here: https://github.com/cognitivecomputations/spectrum/pull/6
Great. Thanks!
I'm taking my first steps with Spectrum. Great work!
I find it difficult to run it on notebooks, mostly because of
prompt_toolkit
, but I understand it is convenient, especially for weights selection.However, I believe the script could benefit from a couple of improvements:
if __name__ == "__main__":
blockself.optimizer
andself.tokenizer
are initialized but never actually used.@Crystalcareai What do you think? If these observations make sense, I'd be more than happy to open a PR to address them.