search

coiled / benchmarks

BSD 3-Clause "New" or "Revised" License
28 stars 17 forks source link

Migrate AB and CI dependencies off conda to pip-compile #1447

Closed milesgranger closed 6 months ago

milesgranger commented 6 months ago

Will close #1437

Moves dependencies to new AB_<name>.requirements.txt file, which is dependabot friendly for automated upgrades. Alone w/ the associated dependabot.yml file configured to look in AB_environments directory.

milesgranger commented 6 months ago

Successful A/B run here: https://github.com/coiled/benchmarks/actions/runs/8246636881

milesgranger commented 6 months ago

@crusaderky, it seemed to get unwieldy needing to copy around a core set of requirements to so many files when moving to pip. Therefore I've converted to pip-compile so we can include these in other environments, by just adding -r requirements.in or similar both in CI and AB environments. Then just two conda env files, one for the base to determine python version and stuff like openssl and openjdk which is easier w/ conda, then one for updating to git-tip.

Done in https://github.com/coiled/benchmarks/pull/1447/commits/d628ccee9253acb9f3bff8f332bf2643761a6c40, let me know what you think.

crusaderky commented 6 months ago

@milesgranger I've gone through all the documentation; please review. If you're happy with it I think we can merge?